-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes upgrade from 0.63.x to 1.3.x AC switch OFF and wallet creation failed #4449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor whitespace nit.
const double bat = choices_bat_value.GetDouble(); | ||
wallet_properties.parameters_choices.push_back(bat); | ||
if (choices_bat_list) { | ||
for (const auto&choices_bat_value : choices_bat_list->GetList()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor, but maybe a space after the &
?
CI run was completely green 🎉 I did a quick commit to address that nit, @emerick 😄 Should be ready to merge! |
Sanity tests of fix #4449 have shown that users who experienced this issue will have their data recovered after upgrading as long the user did not try to re-enable Brave Rewards. If a user did re-enable Rewards before upgrading to this fix then the wallet will be corrupted and is non-recoverable. Sanity testing was from 0.63.55 to 1.3, 1.4 and 1.5, however, we should test other scenarios. As a side note P3A is broken for wallet creation as it still references Probi etc. which does not exist in the JSON feed. I will raise a separate issue for this. |
Verified using
PASS Upgrading without hitting the issue first:
PASS Upgrading after hitting the issue first:
Note - see #4449 (comment) for additional information PASS Sanity check of other upgrades:
|
Fixes brave/brave-browser#7833
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See brave/brave-browser#7833 (resets Ads viewed count to zero is a known issue and was agreed that migration would not be attempted for brave/brave-browser#4047)
Reviewer Checklist:
After-merge Checklist:
changes has landed on.