updata add-update: don't create manifest, require 'init' first #991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically creating a manifest during
add-update
can be problematic if youthought the manifest path did exist. You may create an empty repo instead of
adding to one as intended.
This change requires "init" to be run first, so you're showing your intention
to create a new repo.
This happened to us during the 0.4.1 release when making a test repo that we expected to include older versions as well.
Testing done:
Before, it runs regardless of whether the manifest ("not-a-file") exists:
It creates an empty manifest, then inserts the update, when I intended to add to an existing repo:
After, it fails in the expected way when the file doesn't exist. (Works as expected after
init
ing the file.)Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.