Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert MIG changes #4405

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Revert MIG changes #4405

merged 2 commits into from
Feb 19, 2025

Conversation

koooosh
Copy link
Contributor

@koooosh koooosh commented Feb 18, 2025

Issue number:

Related to: #4406

Description of changes:

Reverts MIG-related changes included in #4306:

Testing done:

N/A

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@koooosh koooosh marked this pull request as ready for review February 18, 2025 23:09
@piyush-jena
Copy link
Contributor

piyush-jena commented Feb 18, 2025

I tested the changes with the latest kernel and core-kit and it works (customers can't set MIG settings and nvidia-migmanager.service won't run.)

root@admin]# sheltie
bash-5.1# journalctl -u nvidia-migmanager
Feb 18 23:16:55 ip-172-31-3-49.us-west-2.compute.internal systemd[1]: NVIDIA MIG manager service was skipped because of an unmet condition check (ConditionPathExists=/etc/nvidia-migmanager/nvidia-migmanager.toml).
Feb 18 23:16:56 ip-172-31-3-49.us-west-2.compute.internal systemd[1]: NVIDIA MIG manager service was skipped because of an unmet condition check (ConditionPathExists=/etc/nvidia-migmanager/nvidia-migmanager.toml).
bash-5.1# apiclient set settings.kubelet-device-plugins.nvidia.device-partitioning-strategy="mig"
Failed to change settings: Failed PATCH request to '/settings/keypair?tx=apiclient-set-xV2ypW3aat087Fem': Status 400 when PATCHing /settings/keypair?tx=apiclient-set-xV2ypW3aat087Fem: Unable to match your input to the data model.  We may not have enough type information.  Please try the --json input form.  Cause: Error during deserialization: unknown field `device-partitioning-strategy`, expected one of `pass-device-specs`, `device-id-strategy`, `device-list-strategy`, `device-sharing-strategy`, `time-slicing` at line 1 column 67
bash-5.1# apiclient apply <<EOF
> [settings.kubelet-device-plugins.nvidia.mig.profile]
> "a100.40gb"="3"
> "h100.80gb"="4"
> "g100.80gb"="1g.5gb"
> EOF
Failed to apply settings: Failed to PATCH settings from '-' to '/settings?tx=apiclient-apply-S5yboyYbXvJfGHWt': Status 400 when PATCHing /settings?tx=apiclient-apply-S5yboyYbXvJfGHWt: Json deserialize error: unknown field `mig`, expected one of `pass-device-specs`, `device-id-strategy`, `device-list-strategy`, `device-sharing-strategy`, `time-slicing` at line 1 column 42
bash-5.1#

@koooosh koooosh merged commit cb6c280 into bottlerocket-os:develop Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants