-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3p packages update 1.19.3 #3832
Changes from all commits
9da1466
0f74296
5c37b86
e7e6c5f
01678dc
d94f4c1
05d84e0
0a534fa
162cfb1
cdb9b0d
78df5a6
243fc23
b149b0f
9794eb5
5c54ce1
b8d9f7d
cf907cf
587eaff
bc37d4e
bfd44a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,8 +12,8 @@ path = "../packages.rs" | |
releases-url = "/~https://github.com/linux-audit/audit-userspace/releases" | ||
|
||
[[package.metadata.build-package.external-files]] | ||
url = "/~https://github.com/linux-audit/audit-userspace/archive/v3.1.2/audit-userspace-3.1.2.tar.gz" | ||
sha512 = "d5b05686aedd6eaaced000778580bd3e96e38c020534038d6b1ee6de96dd7687c2f3a52a2ae75be8b93c173b286a56dbc92231906c68fda79b113dfcaad6da84" | ||
url = "/~https://github.com/linux-audit/audit-userspace/archive/v3.1.3/audit-userspace-3.1.3.tar.gz" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's fine to stay on 3.x for now, but it should also be possible to move up to audit 4 - or if it's not, we should at least have tried it and have a sense of what's broken. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. |
||
sha512 = "3e21af2a43e103dd38b65bb1fbfcbe5da2aae1a883218edd80dc715d4ed5fc8980b964469dadf42040f35fab9bfb4b0224b299aafb622a11f48e9f388103b6f0" | ||
|
||
[build-dependencies] | ||
glibc = { path = "../glibc" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd like to see the addition of these as their own commit and down by the rest of the exports (probably after
export %{kube_cc}
along with a comment explaining that we want to override the Go specification since we bring our own Go toolchain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed about putting them in their own commit (
kubelet: set FORCE_HOST_GO=1 in environment
).But it does need to be set here, before
make generated_files
is invoked, or it will try again to download the Go toolchain for codegen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting, I didn't realize they used go in the codegen :| Ok, then I agree that is where it should be.