settings: add kernel settings extension #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Berning <bernings@amazon.com>
Signed-off-by: Sam Berning <bernings@amazon.com>
Signed-off-by: Sam Berning <bernings@amazon.com>
sam-berning
force-pushed
the
kernel-settings-extension
branch
from
39cb3a7 to
f4a4e8c
Compare
webern
approved these changes
Jan 24, 2024
Yeah, we can just get rid of the Settings structs once the API is set up to interact with settings extensions. See this section of the settings extension design doc for an explanation of how the OS will understand settings -- it'll basically only know that it's json but nothing about what the structure should be. |
bcressey
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3653
Description of changes:
Ports kernel settings to a settings extension.
Testing done:
Built an aws-dev variant with the
settings-kernelpackage installed, and launched an ec2 instance with it.Kernel settings in the API and the setting extension both behaved as expected.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.