systemd: stop building gpt-auto-generator to avoid remounting /boot #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During boot prairiedog figures out which partition bank is in use and mounts the correct boot partition containing the kernel binary and configuration at /boot. When an x86 system booted via BIOS/CSM, it was observed that at some point after boot the EFI System Partition would be mounted at /boot instead. The cause for the unexpected remount is systemd-gpt-auto-generator, a generator running during systemd start that creates mount and automount units for well-known partition GUIDs. This undoes the work previously performed by prairiedog. Convincing gpt-auto-generator to do right by Bottlerocket would involve changing partition GUIDs and implementing logic for the GPT priority fields. Alternatively, gpt-auto-generator can be disabled at boot via the `systemd.gpt_auto=0` kernel command line option, leaving the work of mounting partitions to prairiedog and other already existing mount units. Since we would disable the gpt-auto-generator via the kernel command line for all variants, we might as well stop building and shipping it. Add a local patch to allow selecting/deselecting gpt-auto-generator at build-time and actually deselect it. Signed-off-by: Markus Boehme <markubo@amazon.com>
bcressey
approved these changes
Nov 10, 2023
yeazelm
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3539
Description of changes:
Stop building
systemd-gpt-auto-generator. That generator creates (auto)mount units based on partition GUIDs that interfere with prairiedog mounting theBOTTLEROCKET-BOOTpartition at/boot. Please see the commit message for details.Testing done:
Booting
metal-devon x86_64 via BIOS, waiting a few minutes, checking the contents of/boot./booteventually.BOTTLEROCKET-BOOTpartition identified by prairiedog remains mounted at/boot.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.