buildsys: Add option to force upstream source usage for specific packages #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we decide to do this we may want to simplify the special casing for nvidia variants in our github workflows. |
For some packages we build in Bottlerocket we can not cache the external files for licensing restrictions (i.e. nvidia drivers). These packages will always fail to build without having the package downloaded previously or setting `BUILDSYS_UPSTREAM_SOURCE_FALLBACK=true` in the environment. Add an optional setting for external files enabling forcing upstream fallback. This can be added to those packages we never intend to upload to the lookaside cache. Signed-off-by: Leonard Foerster <foersleo@amazon.com>
We will not upload the nvidia driver sources to our lookaside cache. As they always have to come from upstream, force getting the files from there. Signed-off-by: Leonard Foerster <foersleo@amazon.com>
foersleo
force-pushed
the
buildsys_per_package_upstream
branch
from
4c53f1c to
aea18de
Compare
|
⬆️ Force push fixed the formatting issue I produced. First time rust contributor in Bottlerocket, so please be patient with me. |
yeazelm
approved these changes
Aug 9, 2023
etungsten
approved these changes
Aug 9, 2023
markusboehme
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: -
Description of changes:
When building packages and we do not find the appropriate source files in the look-aside cache
we do not check the upstream source by default. We can allow using upstream as a fallback through
setting
BUILDSYS_UPSTREAM_SOURCE_FALLBACK=truein the environment.However, for some packages (i.e. nvidia drivers) we will never vend a copy of the upstream sources
in the look-aside cache for licensing reasons. With the linux-firmware package (#3296) we will probably grow another package that falls into that category.
Add an optional setting for
external-filesto force the use of upstream sources to allow these packagesto not derail a build where we forget to set the appropriate environment variable. Select the always upstream
source lookup for all nvidia kmod packages.
Testing done:
Building the nvidia kmod packages without specifying
-e BUILDSYS_UPSTREAM_SOURCE_FALLBACK=trueworks:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.