-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.13.x] Cherrypicks for 1.13.4 #3042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets the 'settings.kubernetes.cloud-provider' setting control what gets passed to '--cloud-provider' in kubelet options
…s-1.26 This separates the model for aws-k8s-1.26 so that we generate the 'hostname-override' setting and set the cloud-provider to 'external' for aws-k8s-1.26 variants only.
Adds a new command for retrieving the instance's PrivateDnsName. Refactors out code for setting up proxy for the AWS API clients so it can be shared between the EKS module and EC2 module.
This adds the 'kubernetes.hostname-override' setting for kubelet's '--hostname-override' option.
Updates runc to v1.1.6
The `fetch_hostname` method queries the `metadata/local-hostname` IMDS target, which has the potential to return multiple space-delimited hostnames. This changes the method to return only the first hostname in the list.
webern
approved these changes
Apr 20, 2023
yeazelm
approved these changes
Apr 20, 2023
yeazelm
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New change for the version mismatch looks good.
cbgbt
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Cherry picks changes from:
--hostname-override
to kubelet, set it to inst.PrivateDnsName
for k8s-1.26 #3033fetch_hostname
#3032As well as updating the version in Release.toml
Testing done:
N/A
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.