-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pubsys: fix AWS SDK API calls and surface service error codes #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This surfaces the actual AWS API service error code in the error log message.
jpmcb
approved these changes
Mar 14, 2023
rpkelly
approved these changes
Mar 14, 2023
jpculp
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ran
pubsys
directly to revoke user ids - Ran
pubsys
directly to grant user ids - Published ami with
cargo make -e BUILDSYS_ARCH=x86_64 -e BUILDSYS_VARIANT=aws-k8s-1.24 ami
- Granted permissions to ami with
cargo make -e BUILDSYS_ARCH=x86_64 -e BUILDSYS_VARIANT=aws-k8s-1.24 -e GRANT_TO_USERS=XXXXXXXXX grant-ami
The EC2 API call for modify-snapshot-attribute and modify-image-attribute errors on empty vecs. This passes 'None' for the list parameters if the list is empty.
Ensure we pass None if the list of names we're passing is empty.
Push above changes the |
jpculp
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-ran the same cargo make
tests. LGTM!
This was referenced Mar 15, 2023
jpmcb
added a commit
to jpmcb/bottlerocket
that referenced
this pull request
Mar 15, 2023
Related to: bottlerocket-os#2895 Signed-off-by: John McBride <jpmmcb@amazon.com>
jpmcb
added a commit
to jpmcb/bottlerocket
that referenced
this pull request
Mar 15, 2023
Related to: bottlerocket-os#2895 Signed-off-by: John McBride <jpmmcb@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Testing done:
@jpculp ran the tests:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.