Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13.0: Update CHANGELOG.md #2856

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Mar 6, 2023

Issue number:

Closes #2767

Description of changes:

Updates changelog with current changes on the develop branch since the v1.12 tag

Testing done:

N/a

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Just a few questions inline, that may just be due to me not really knowing who the target audience is for this. ;)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jpmcb
Copy link
Contributor Author

jpmcb commented Mar 6, 2023

@stmcginnis I ended up including everything from the v1.12 tag on-wards. It seems that previous changelog updates are somewhat selective in what to include, but would at times also have internal details (like in the Build Changes section). So I'm not sure how granular to be.

@jpmcb jpmcb force-pushed the changelog-v1.13 branch from 0c4e28a to ffc195d Compare March 6, 2023 20:05
@jpmcb
Copy link
Contributor Author

jpmcb commented Mar 6, 2023

Force pushed to address Sean's comments: I moved the "internal" details under the Build Changes section where it looks like we've put those things in the past.

@jpmcb jpmcb force-pushed the changelog-v1.13 branch from ffc195d to a16ccee Compare March 6, 2023 20:17
@jpmcb
Copy link
Contributor Author

jpmcb commented Mar 6, 2023

Force pushed to add some missing PR links. Visually verified here: /~https://github.com/jpmcb/bottlerocket/blob/changelog-v1.13/CHANGELOG.md

@jpmcb jpmcb force-pushed the changelog-v1.13 branch 2 times, most recently from 73834ba to 1a86253 Compare March 13, 2023 16:48
CHANGELOG.md Outdated Show resolved Hide resolved
@jpmcb jpmcb force-pushed the changelog-v1.13 branch 2 times, most recently from 414778b to 4725f83 Compare March 13, 2023 16:53
@jpmcb jpmcb marked this pull request as ready for review March 13, 2023 16:53
CHANGELOG.md Outdated Show resolved Hide resolved
@jpmcb jpmcb force-pushed the changelog-v1.13 branch 3 times, most recently from b61853c to a09a372 Compare March 13, 2023 17:03
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jpmcb jpmcb force-pushed the changelog-v1.13 branch from a09a372 to d9b2ba8 Compare March 13, 2023 17:34
@jpmcb jpmcb requested a review from bcressey March 13, 2023 17:35
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jpmcb jpmcb force-pushed the changelog-v1.13 branch from d9b2ba8 to 5145bf9 Compare March 13, 2023 18:03
@jpmcb jpmcb requested a review from bcressey March 13, 2023 18:16
CHANGELOG.md Show resolved Hide resolved
@jpmcb jpmcb force-pushed the changelog-v1.13 branch from 5145bf9 to 275b370 Compare March 13, 2023 19:27
CHANGELOG.md Show resolved Hide resolved
Signed-off-by: John McBride <jpmmcb@amazon.com>
@jpmcb jpmcb force-pushed the changelog-v1.13 branch from 275b370 to b7b71ce Compare March 13, 2023 20:23
@jpmcb jpmcb merged commit b1ac8ef into bottlerocket-os:develop Mar 13, 2023
@jpmcb jpmcb deleted the changelog-v1.13 branch March 13, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.13.0 Update CHANGELOG.md
8 participants