Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: add image credential provider settings #2547

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

stmcginnis
Copy link
Contributor

Issue number:

Related #1702

Description of changes:

Add kubelet config option credential-providers to allow configuring image credential provider settings.
Mention of the new settings have been added to the README.

Testing done:

Deployed instance. Testing settings by running:

apiclient set -j '{"kubernetes": {"credential-providers": {"ecr-credential-provider": {"enabled": true, "image-patterns": []}}}}'
apiclient get settings.kubernetes

See #2377 for complete testing details.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@stmcginnis stmcginnis mentioned this pull request Nov 3, 2022
14 tasks
Add kubelet config option `credential-providers` to allow configuring
image credential provider settings.

Mention of the new settings have been added to the README, but more
detailed documentation on how to use the feature will be necessary.
Those docs will be added in a future commit.

Signed-off-by: Sean McGinnis <stmcg@amazon.com>
@stmcginnis
Copy link
Contributor Author

Rebased on develop to resolve merge conflicts.

@stmcginnis stmcginnis merged commit 538b9bb into bottlerocket-os:develop Nov 3, 2022
@stmcginnis stmcginnis deleted the cred-prov-settings branch November 3, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants