schnauzer: Add any_enabled template helper #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
force-pushed
the
cred-prov-any_enabled
branch
from
db6030c to
c63df8a
Compare
webern
approved these changes
Nov 1, 2022
|
I think depending on the resolution of #2377 (comment), we might need to change this from interpreting a list to a map. |
Hmm, this may be an issue. Not sure how that would be handled using handlebar syntax. Maybe another helper that would convert the items in the hashmap into a list that would then be passed in to this helper? |
This adds a new template helper called `any_enabled` that can be used in our templates to check if anything in a collection contains something with the property of `enabled` set to true. The helper looks for an array, then checks that the objects within the array has an "enabled" property. If they do and if any of them are set to "true" the condition evaluates to be "truey" for conditional blocks within the template. If the passed in value is not an array, does not have an "enabled" property, or has no elements with that property set to true it will evaluate to falsey. Signed-off-by: Sean McGinnis <stmcg@amazon.com>
stmcginnis
force-pushed
the
cred-prov-any_enabled
branch
from
c63df8a to
dd29094
Compare
Added ability to also use a map as input with unit test coverage for various input. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related #1702
Description of changes:
This adds a new template helper called
any_enabledthat can be used in our templates to check if anything in a collection contains something with the property ofenabledset to true.The helper looks for an array, then checks that the objects within the array has an "enabled" property. If they do and if any of them are set to "true" the condition evaluates to be "truey" for conditional blocks within the template.
If the passed in value is not an array, does not have an "enabled" property, or has no elements with that property set to true it will evaluate to falsey.
Testing done:
See #2377 for complete testing details.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.