-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws-k8s-1.22, vmware-k8s-1.22, aws-k8s-1.22-nvidia, metal-k8s-1.22 variants #1962
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, pending testing.
7277052
to
b498e83
Compare
nit: commit for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I know there's a staggering amount of copy/paste and fiddly edits but it all looks right to me.
Push above rebases onto develop to pull in latest changes. |
Push above addresses @bcressey 's comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏷️
Push above updates the k8s-1.22 package to the latest EKS-D dev release. |
Push above rebases onto develop and fixes conflicts |
Use K8s 1.22 source from EKS-D
Adds aws-k8s-1.22 variant, relinks symlinks in models
Adds vmware-k8s-1.22 variant, relinks symlinks in models Update example vmware k8s version in quickstart to v1.21
Adds aws-k8s-1.22-nvidia variant, create symlinks for previous k8s version nvidia variant in models.
This change adds an additional variant `metal-k8s-1.22`, which includes necessary Kubernetes packages and settings for running Bottlerocket on metal in a Kubernetes v1.22 cluster.
Push above flips the |
Having two disks in the OVF template can trigger sporadic issues when importing into the vSphere content library. Switching to the unified layout should avoid this failure mode. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Push above adds a commit for changing the image layout for vmware-k8s-1.22 to unified. Tested the vmware-k8s-1.22 variant and conformance tests passed. |
vmware-k8s variants have graduated from preview status.
Push above removes note about vmware variant's preview status from README and QUICKSTART-VMWARE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌡️
Issue number:
Resolves #1961
Description of changes:
For reference, the addition of k8s-1.21 variants was in #1612
Testing done:
... Others TBD
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.