-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: constrain ip_local_port_range #1560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this change overall, but we should reference #1386 and also the containerd port collision in the commit message, to document why we're doing it.
^ Push above updates commit message to elaborate on reasons why we're making this change. |
^ fixes typo in commit message. |
containerd listens on ports in the kernel's ephemeral port range which can conflict with fixed ports kubelet needs when it starts up. This limits the ephemeral port range for all Bottlerocket variants and not just aws-ecs-1 and aws-k8s-1.20.
Push above touches up the commit message. |
Issue number:
Fixes #1386 more definitively
Description of changes:
Testing done:
Build aws-k8s-1.19 image and launched instance. Checked sysctl and saw that the ephemeral port range is set correctly.
Ports being used:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.