pubsys: change "parameter overrides" to "conditional parameters" #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Aug 24, 2020
webern
approved these changes
Aug 24, 2020
etungsten
approved these changes
Aug 24, 2020
Rather than template directories with override files for specific variants and architectures, this uses a single TOML file for all parameters with (optional) keys restricting parameters to specific variants and arches. This model is clearer, based on early feedback, and also allows users to specify parameters that are conditional to a variant *and* an architecture, whereas the override files were more like "or" matches.
tjkirch
force-pushed
the
ssm-conditional-params
branch
from
7f376dc to
7a65061
Compare
|
^ trivial rebase on develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: based on #1060.
Testing done:
I added parameters specific to current arch, to another arch, to current variant, to another variant, to lists of variants/arches separately, to lists of variants/arches together (for matching and non-matching combinations), and overall saw the expected behavior as described in the updated README.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.