-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo make ami-public
and ami-private
targets
#1033
Conversation
Co-authored-by: Zac Mrowicki <mrowicki@amazon.com> Co-authored-by: Tom Kirchner <tjk@amazon.com>
Co-authored-by: Zac Mrowicki <mrowicki@amazon.com> Co-authored-by: Tom Kirchner <tjk@amazon.com>
Co-authored-by: Zac Mrowicki <mrowicki@amazon.com> Co-authored-by: Tom Kirchner <tjk@amazon.com>
dc4d53b
to
81eca19
Compare
81eca19
to
abb5b86
Compare
^ Addresses @bcressey's comment above; per offline discussion, rather than an exact match, we check that the requested regions are a subset of the ones in the JSON file, in case a user only wants to publish in some of their regions at first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Co-authored-by: Zac Mrowicki <mrowicki@amazon.com> Co-authored-by: Tom Kirchner <tjk@amazon.com>
abb5b86
to
58d03cf
Compare
^ This push addresses @webern's comment about the inaccurate description of the regions parameter. I think the other comments are OK. |
Description of changes:
Testing done:
cargo make ami-public/private
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.