This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
introduce initialMmapSize #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InitialMmapSize is the initial mmap size of the database in bytes. Read transaction is guaranteed not to block write transaction if the mmap size required by the database is smaller than the initial mmap.
|
/cc @ngaut Probably you are also interested in this one? |
| // InitialMmapSize is the initial mmap size of the database | ||
| // in bytes. | ||
| // | ||
| // Read transaction is guaranteed not to block write transaction |
There was a problem hiding this comment.
"Read transactions are guaranteed not to block write transactions ..."
|
@xiang90 were you able to test this out on etcd? |
|
@benbjohnson We will test it before early next week. Sorry for the delay. |
|
@benbjohnson Yes. We tested it in both etcd and a test case. It works well. See #472 for more information. @gyuho is taking over this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InitialMmapSize is the initial mmap size of the database in bytes.
Read transaction is guaranteed not to block write transaction
if the mmap size required by the database is smaller than
the initial mmap.