feat: be/unified uptime query #1533
Conversation
![llamapreview[bot]](/~https://avatars.githubusercontent.com/in/1023541?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto Pull Request Review from LlamaPReview
Large PR Notification
Dear contributor,
Thank you for your substantial contribution to this project. LlamaPReview has detected that this Pull Request contains a large volume of changes, which exceeds our current processing capacity.
Details:
- PR and related contents total size: Approximately 65,199 characters
- Current limit: 50,000 characters
Next steps:
- Consider breaking this PR into smaller, more focused changes if possible.
- For manual review, please reach out to your team members or maintainers.
We appreciate your understanding and commitment to improving this project. Your contributions are valuable, and we want to ensure they receive the attention they deserve.
LlamaPReview is continuously evolving to better serve the community. Share your thoughts on handling large PRs in our GitHub Discussions - your feedback helps us improve and expand our capabilities.
If you have any questions or need assistance, our community and support team are here to help.
Best regards,
LlamaPReview Team
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces significant changes to the monitoring system's data retrieval and state management across both client and server components. The modifications primarily focus on streamlining monitor data fetching, removing Redux-based actions, and implementing more direct API interactions. The changes affect multiple files in the client and server repositories, restructuring how monitor data is retrieved, validated, and displayed. Changes
Sequence DiagramsequenceDiagram
participant Client
participant NetworkService
participant Server
participant Database
Client->>NetworkService: Request monitors by team ID
NetworkService->>Server: GET /team/:teamId
Server->>Database: Aggregate monitor data
Database-->>Server: Return monitors and summary
Server-->>NetworkService: Respond with data
NetworkService-->>Client: Update local state with monitors
Possibly Related PRs
Suggested Reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (13)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This PR unifies two separate queries that were made in order to fetch monitors. Previously, one query was made for a summary of monitors, one query made for a list of monitors with checks. Now one query is made using the aggregate pipeline and facets in order to get all the data in one go.
In order to make use of these queries some changes were requried on the FE. There is no need to store these monitors in the redux state any longer, so fetching has been moved to the component. Unnecessary redux thunks are removed and loading managed locally.
getMonitorsByIdandgetMonitorsSummarymethods to use the new unified method.