Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Account Center Updates #1723

Merged
merged 18 commits into from
May 18, 2023
Merged

Enhancement: Account Center Updates #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
593f392
move default position to bottomRight
leightkt May 11, 2023
a46a006
changes to minimized
leightkt May 11, 2023
3832095
toggle on minimized click
leightkt May 11, 2023
1e4e0e0
fix transition
leightkt May 15, 2023
66d02b6
merge develop
leightkt May 15, 2023
10ff104
fix jump on transition
leightkt May 15, 2023
0917993
rename components
leightkt May 16, 2023
0ab4f6d
remove unused variable
leightkt May 16, 2023
920b4e4
remove unused import
leightkt May 16, 2023
f9f63ee
Merge branch 'develop' into account-center-updates
leightkt May 16, 2023
9e721e0
Merge branch 'develop' into account-center-updates
leightkt May 17, 2023
e484bee
add zindex to triggers
leightkt May 17, 2023
9300b4d
fix duplicate accountCenter issue
leightkt May 17, 2023
79def06
Merge branch 'account-center-updates' of github.com:blocknative/web3-…
leightkt May 17, 2023
ea47dc3
make key accountCenter
leightkt May 17, 2023
cac5d38
reenable off center click to minimize, fix duplicate issue
leightkt May 17, 2023
4677255
add warning about default position change
leightkt May 18, 2023
0736f3a
change warning to tip
leightkt May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions docs/src/routes/docs/[...3]modules/[...1]core/+page.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@ title: Core

This is the core package that contains all of the UI and logic to be able to seamlessly connect user's wallets to your app and track the state of those wallets. Onboard no longer contains any wallet specific code, so wallets need to be passed in upon initialization.

:::admonition type="tip"
_note: Release 2.23.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_
```typescript
accountCenter: {
desktop: {
enabled: true,
position: 'topRight'
},
mobile: {
enabled: true,
position: 'topRight'
}
}
```
:::

## Install

Install the core module:
Expand Down
14 changes: 14 additions & 0 deletions packages/core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,20 @@

This is the core package that contains all of the UI and logic to be able to seamlessly connect user's wallets to your app and track the state of those wallets. Onboard no longer contains any wallet specific code, so wallets need to be passed in upon initialization.

_Tip: Release 2.23.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_
```typescript
accountCenter: {
desktop: {
enabled: true,
position: 'topRight'
},
mobile: {
enabled: true,
position: 'topRight'
}
}
```

## Quick start

Checkout our full library of quick start examples for connecting and interacting with EVM based wallets
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@web3-onboard/core",
"version": "2.18.1-alpha.2",
"version": "2.18.1-alpha.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is changing the default way core displays I am thinking we should make this a minor version bump

"description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
"keywords": [
"Ethereum",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const APP_INITIAL_STATE: AppState = {
chains: [],
accountCenter: {
enabled: true,
position: 'topRight',
position: 'bottomRight',
expanded: false,
minimal: configuration.device.type === 'mobile'
},
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/views/Index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,6 @@
.container {
padding: 16px;
font-family: var(--onboard-font-family-normal, var(--font-family-normal));
width: 100%;
pointer-events: none;
touch-action: none;
}
Expand Down
Loading