Auth/PM-18574 - ExtensionAnonLayoutWrapperComp - add inline flex to logo so it vertically centers #13546
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o it vertically centers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13546 +/- ##
=======================================
Coverage 35.85% 35.85%
=======================================
Files 3164 3164
Lines 93270 93270
Branches 16981 16981
=======================================
Hits 33440 33440
Misses 57244 57244
Partials 2586 2586 ☔ View full report in Codecov by Sentry. |
|
|
Great job, no security vulnerabilities found in this Pull Request |
Patrick-Pimentel-Bitwarden
approved these changes
Feb 25, 2025
JaredSnider-Bitwarden
deleted the
auth/pm-18574/extension-anon-layout-center-logo-vertically
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18574
📔 Objective
To fix the
ExtensionAnonLayoutWrapperComponent'sstyling of the logo so that it centers vertically in the popup header.📸 Screenshots
Before:
After:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes