Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

providers: add OpenID Connect provider #165

Closed
wants to merge 2 commits into from
Closed

providers: add OpenID Connect provider #165

wants to merge 2 commits into from

Conversation

philips
Copy link
Contributor

@philips philips commented Nov 9, 2015

See the README for usage with Dex or any other OIDC provider.

This has only been tested against CoreOS Dex but should work against
other providers like Google, Facebook, etc as well.

To try it out see the improved Dex docs here: dexidp/dex#176

@philips philips force-pushed the add-oidc-with-go-code-style branch 4 times, most recently from 52c9100 to 1c886b1 Compare November 9, 2015 05:23
This was referenced Nov 9, 2015
Closed
Merged
@philips
Copy link
Contributor Author

philips commented Nov 9, 2015

Quick demo video: https://www.youtube.com/watch?v=cbiAhIUl8Hg&feature=youtu.be

@jehiah
Copy link
Member

jehiah commented Nov 9, 2015

@philips thanks! This sounds great 🎉 I'd like to land this feature separately from the style changes so i've merged #164. Can you rebase this?

I'll familiarize myself with OIDC and give you some feedback here shortly =)

@philips philips force-pushed the add-oidc-with-go-code-style branch from 1c886b1 to 997ea28 Compare November 9, 2015 16:51
@philips philips changed the title Add oidc with go code style providers: add OpenID Connect provider Nov 9, 2015
@philips
Copy link
Contributor Author

philips commented Nov 9, 2015

@jehiah rebased. I would like @bobbyrullo or @bcwaldon to review too since this is the first time I have used the go-oidc library.

Brandon Philips added 2 commits November 9, 2015 08:53
providers: add OpenID Connect provider
7365b2c 
See the README for usage with Dex or any other OIDC provider.

This has only been tested against CoreOS Dex but should work against
other providers like Google, Facebook, etc as well.
Godeps: add github.com/coreos/go-oidc
52e7f91 
New dependency for the go-oidc provider on the CoreOS Go OIDC library.
@philips philips force-pushed the add-oidc-with-go-code-style branch from 997ea28 to 52e7f91 Compare November 9, 2015 16:53
@philips
Copy link
Contributor Author

philips commented Nov 12, 2015

ping @bobbyrullo @bcwaldon @jehiah

@bobbyrullo
Copy link

sorry, not been keeping up with Github notifications very well. Taking a look now.

@dholth dholth mentioned this pull request Aug 22, 2016
Closed
@janwillies janwillies mentioned this pull request Dec 18, 2016
Closed
@emmanuel
Copy link

Is this likely to get merged into mainline? I see that CoreOS is maintaining a fork at /~https://github.com/coreos/oauth2_proxy which looks like it includes this functionality. If I want to use the proxy with OIDC today, I'm wondering if I should focus on CoreOS' fork, or on this upstream original.

@philips
Copy link
Contributor Author

philips commented Apr 5, 2017

cc @ericchiang

@ericchiang
Copy link
Contributor

Yeah I can take a crack at revamping the PR.

@gtaylor
Copy link

gtaylor commented May 9, 2017

Is there anything we can do to help get this merged?

@ericchiang ericchiang mentioned this pull request May 9, 2017
Merged
@ericchiang
Copy link
Contributor

Updated PR here #389

@philips philips closed this May 9, 2017
@philips
Copy link
Contributor Author

philips commented May 9, 2017

Closed in favor of #389

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement new-provider
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@philips @jehiah @bobbyrullo @emmanuel @ericchiang @gtaylor