[#230] Fix loading animation in new design #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klappradla
commented
Apr 30, 2020
| @@ -32,11 +32,11 @@ | |||
| } | |||
|
|
|||
| @keyframes spinner-bouncedelay { | |||
| 0%, 80%, 100% { | |||
Center the spinner animation inside the popup window. closes #230
klappradla
force-pushed
the
feature/230-fix-loading-animation-in-new-design
branch
from
fdb9875 to
fee4607
Compare
pmeinhardt
approved these changes
Apr 30, 2020
| @@ -1,5 +1,5 @@ | |||
| .spinner { | |||
| margin: 4rem auto 0; | |||
| margin: 2rem auto 2rem; | |||
There was a problem hiding this comment.
Neat! 👍 Much better than the previous version. ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centers the spinner animation inside the popup window (see #230):
Thanks to @pmeinhardt for pointing to these nifty debugging tools 🧙♂️