Skip to content

Commit

Permalink
Check Fetch InstrumentationScope from ReadableSpan for PHP (open-tele…
Browse files Browse the repository at this point in the history
…metry#2622)

OTEL-PHP at some point switched to using InstrumentationScope instead of InstrumentationLibrary everywhere, which incidentally satisfied the ["Fetch InstrumentationScope from ReadableSpan"](/~https://github.com/open-telemetry/opentelemetry-specification/blob/9abbdd39d0b35f635f833f072013431da419894e/specification/common/mapping-to-non-otlp.md#instrumentationscope) part of the spec (otel-php is still alpha so it seemed ok to not deprecate the instrumentation library and just remove it's use entirely)

Related issues #
open-telemetry/opentelemetry-php#705

Related [OTEP(s)](/~https://github.com/open-telemetry/oteps) #
Don't think it was an OTEP but open-telemetry#2276 is where the push for the change originally came from I believe
  • Loading branch information
Grunet authored and beeme1mr committed Aug 31, 2022
1 parent ddf1028 commit bf996f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec-compliance-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ formats is required. Implementing more than one format is optional.
| [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | + | + | | - | | + |
| [Built-in `SpanProcessor`s implement `ForceFlush` spec](specification/trace/sdk.md#forceflush-1) | | | + | | + | + | + | + | + | + | + | |
| [Attribute Limits](specification/common/README.md#attribute-limits) | X | | + | | | | + | + | | | | |
| Fetch InstrumentationScope from ReadableSpan | | | + | | | | | | | | | |
| Fetch InstrumentationScope from ReadableSpan | | | + | | | | | + | | | | |

## Baggage

Expand Down

0 comments on commit bf996f7

Please sign in to comment.