-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New StickyIndicator #248
Merged
Merged
New StickyIndicator #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into sticky-indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
StickyNavigationIndicator
to match the new Win 11 Design.Fixes #173
Fixes #178
_NavigationBody
toInheritedNavigationView
NavigationIndicatorState.sizes
. Size, if necessary, can be fetched usingLayoutBuilder
.offsets
is untouchedPaneItem
instead ofNavigationPane
NavigationPane
In general, the performance improvement is for both sticker and end indicators, since they no longer depends on global coordiantes to render. This also fixes the issue that the indicator was still shown even if the item was hidden by the pane scroll view.
I know this comes with limitations, but the gains are better than the losses.
Pre-launch Checklist
CHANGELOG.md
with my changes