Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sliders (#116) #118

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Fix sliders (#116) #118

merged 3 commits into from
Dec 23, 2021

Conversation

WinXaito
Copy link
Collaborator

@WinXaito WinXaito commented Dec 22, 2021

Fixes #116

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

As the documentation says:

  /// Whether wrapping the widget in a stack is the approach
  /// that is goind to be used to render the box. If false,
  /// a transparent border is created around the [child] as a
  /// placeholder, and the real border is only displayed when
  /// [focused] is true.
  ///
  /// Using the stack approach is recommended for widgets that
  /// have a defined size (height and width). You should not use
  /// it with widgets that require dragging.
  ///
  /// This property is disabled by default on the following widgets:
  ///   - [Slider]

This property should be true, and, when this is true, the sliders work (and when we focus with keyboard, no layout move are visible)

@bdlukaa bdlukaa merged commit 14fd4d3 into bdlukaa:master Dec 23, 2021
@WinXaito WinXaito deleted the fix_sliders branch December 23, 2021 14:59
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't move Sliders knobs
2 participants