Fix: Update ACA-Py Dependency #24
Conversation
shaangill025
commented
Oct 25, 2023
shaangill025
commented
- resolve Existing installations of ACA-Py are downgraded when installing this plugin #23
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
| python = "^3.9" | ||
| aries-cloudagent = ">= 0.9.0, < 1.0.0" |
There was a problem hiding this comment.
I am good with this for now. I would move ACA-Py to dev dependencies unless we can ensure that the pre-installed version on the image will NOT be overwritten if it doesn't match the expected version.
There was a problem hiding this comment.
The plugins in traction all have an exact acapy dependency. I think for the plugin repo we should have exact acapy dependencies and then tag them. If the parent application wanted to upgrade it's acapy it would need to upgrade the plugin to the latest tag as well. The plugins would be upgraded and tested when acapy upgrades happen.
This does seem slightly dangerous if acapy and the parent application was upgraded to 0.11.0 and the plugin wasn't tested with it.
There was a problem hiding this comment.
I agree with @esune. One question though: How come there are so many lock files?
It looks like there is one for the demo setup, and one for each "independent" plugin component |
