Fix ASN1Parser length parsing #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current length parsing is comparing offset in parsed bytestream to sub-object length. Sometimes this leads to last branch being taken for an object in middle of ASN1Sequence. Due to that, excess bytes are included to encodedBytes. It looks like the intention of the if construct is a bounds check. Fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current length parsing is comparing offset in parsed bytestream to sub-object length. Sometimes this leads to last branch being taken for an object in middle of ASN1Sequence. Due to that, excess bytes are included to encodedBytes. This is observed with some X.509v3 certificates.
It looks like the intention of the if construct is a bounds check. Fix that.