Wire credential helper to repository fetching. #18173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
credhelper-repo-fetch
branch
from
e0c3e38 to
abe83bd
Compare
tjgq
force-pushed
the
credhelper-repo-fetch
branch
4 times, most recently
from
ea84c9c to
f8c13bb
Compare
tjgq
changed the title
tjgq
force-pushed
the
credhelper-repo-fetch
branch
from
f8c13bb to
7137888
Compare
github-actions
bot
added
awaiting-review
tjgq
force-pushed
the
credhelper-repo-fetch
branch
6 times, most recently
from
bd0f1e5 to
3a0ec15
Compare
tjgq
force-pushed
the
credhelper-repo-fetch
branch
from
3a0ec15 to
018baa6
Compare
|
cc @Yannic |
Wyverald
approved these changes
May 16, 2023
src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/DownloadManager.java
Outdated
Show resolved
Hide resolved
Wyverald
added
awaiting-PR-merge
After this change, credential helpers will be used when available to obtain credentials for repository fetching, taking precedence over the `auth` parameter to rctx.download and rctx.download_and_extract. Tests that need a credential helper are skipped on Windows for now, as otherwise the credential helper would have to be reimplemented in Batch or Powershell. Also improve the documentation for credential helper related flags. Fixes bazelbuild#15013.
tjgq
force-pushed
the
credhelper-repo-fetch
branch
from
018baa6 to
571c1dc
Compare
sgowroji
removed
the
awaiting-PR-merge
tjgq
added a commit
to tjgq/bazel
that referenced
this pull request
May 17, 2023
After this change, credential helpers will be used when available to obtain credentials for repository fetching, taking precedence over the `auth` parameter to rctx.download and rctx.download_and_extract. Tests that need a credential helper are skipped on Windows for now, as otherwise the credential helper would have to be reimplemented in Batch or Powershell. Also improve the documentation for credential helper related flags. Fixes bazelbuild#15013. Closes bazelbuild#18173. PiperOrigin-RevId: 532454935 Change-Id: Ia3be8c21e001a36160f3d1df858593f8fb846055
This was referenced May 17, 2023
tjgq
added a commit
to tjgq/bazel
that referenced
this pull request
May 19, 2023
After this change, credential helpers will be used when available to obtain credentials for repository fetching, taking precedence over the `auth` parameter to rctx.download and rctx.download_and_extract. Tests that need a credential helper are skipped on Windows for now, as otherwise the credential helper would have to be reimplemented in Batch or Powershell. Also improve the documentation for credential helper related flags. Fixes bazelbuild#15013. Closes bazelbuild#18173. PiperOrigin-RevId: 532454935 Change-Id: Ia3be8c21e001a36160f3d1df858593f8fb846055
iancha1992
pushed a commit
that referenced
this pull request
May 19, 2023
After this change, credential helpers will be used when available to obtain credentials for repository fetching, taking precedence over the `auth` parameter to rctx.download and rctx.download_and_extract. Tests that need a credential helper are skipped on Windows for now, as otherwise the credential helper would have to be reimplemented in Batch or Powershell. Also improve the documentation for credential helper related flags. Fixes #15013. Closes #18173. PiperOrigin-RevId: 532454935 Change-Id: Ia3be8c21e001a36160f3d1df858593f8fb846055
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
After this change, credential helpers will be used when available to obtain credentials for repository fetching, taking precedence over the `auth` parameter to rctx.download and rctx.download_and_extract. Tests that need a credential helper are skipped on Windows for now, as otherwise the credential helper would have to be reimplemented in Batch or Powershell. Also improve the documentation for credential helper related flags. Fixes bazelbuild#15013. Closes bazelbuild#18173. PiperOrigin-RevId: 532454935 Change-Id: Ia3be8c21e001a36160f3d1df858593f8fb846055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, credential helpers will be used when available to obtain
credentials for repository fetching, taking precedence over the
authparameter to rctx.download and rctx.download_and_extract.
Tests that need a credential helper are skipped on Windows for now, as
otherwise the credential helper would have to be reimplemented in Batch
or Powershell.
Also improve the documentation for credential helper related flags.
Fixes #15013.