Skip to content

Commit

Permalink
Remove spammy logging after bug has been resolved.
Browse files Browse the repository at this point in the history
The other parts should have been removed by bfe0b9c already.

PiperOrigin-RevId: 446026545
  • Loading branch information
meisterT authored and copybara-github committed May 2, 2022
1 parent 9ad0a73 commit 3f9baac
Showing 1 changed file with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;
import com.google.common.flogger.GoogleLogger;
import com.google.devtools.build.lib.actions.ActionContext;
import com.google.devtools.build.lib.actions.ActionExecutionContext;
import com.google.devtools.build.lib.actions.ExecException;
Expand All @@ -28,16 +27,13 @@
import com.google.devtools.build.lib.server.FailureDetails.FailureDetail;
import com.google.devtools.build.lib.server.FailureDetails.Spawn.Code;
import java.util.List;
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;

/**
* Resolver that looks up the right strategy for a spawn during {@link #exec} (via a {@link
* SpawnStrategyRegistry}) and uses it to execute the spawn.
*/
public final class SpawnStrategyResolver implements ActionContext {
private static final GoogleLogger logger = GoogleLogger.forEnclosingClass();

/**
* Executes the given spawn with the {@linkplain SpawnStrategyRegistry highest priority strategy}
* that can be found for it.
Expand Down Expand Up @@ -119,18 +115,8 @@ public List<? extends SpawnStrategy> resolve(
.setMessage(message)
.setSpawn(FailureDetails.Spawn.newBuilder().setCode(Code.NO_USABLE_STRATEGY_FOUND))
.build());
} else {
// Extra logging to debug b/194373457
logger.atInfo().atMostEvery(1, TimeUnit.SECONDS).log(
"Spawn %s resolved with fallback to strategies %s",
spawn.getResourceOwner().describe(), fallbackStrategies);
}
return fallbackStrategies;
} else {
// Extra logging to debug b/194373457
logger.atInfo().atMostEvery(1, TimeUnit.SECONDS).log(
"Spawn %s resolved to strategies %s",
spawn.getResourceOwner().describe(), execableStrategies);
}

return execableStrategies;
Expand Down

0 comments on commit 3f9baac

Please sign in to comment.