Add rules_java 4.0.0 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
force-pushed
the
rules_java
branch
from
068ac0b to
6fd28a7
Compare
Wyverald
approved these changes
Oct 20, 2021
| compatibility_level = 1, | ||
| ) | ||
| bazel_dep(name = "bazel_skylib", version = "1.0.3") | ||
|
|
There was a problem hiding this comment.
just curious, what's our policy for adding the MODULE.bazel file itself as a patch? I see you have done it for some other modules (rules_python for example), but not done it here. It probably doesn't matter too much either way; I just thought we should be consistent.
There was a problem hiding this comment.
Oh, for other modules, it's because I have other changes to patch so the patch for MODULE.bazel was generated together, I should have just removed it since it's not necessary. But ideally both MODULE.bazel and those changes should be upstreamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #7