Stop creating a patch for v5.3.1 upgrades on windows #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the podman artifact verb is used to manage OCI artifacts. the following verbs were added to `podman artifact`: * add * inspect * ls * pull * push * rm Notable items with this PR: * all artifact commands and their output are subject to change. i.e. consider all of this tech preview * there is no way to add a file to an artifact that already exists in the store. you would need to delete and recreate the artifact. * all references to artifacts names should be fully qualified names in the form of repo/name:tag (i.e. quay.io/artifact/foobar:latest) * i understand that we will likely want to be able to attribute things like arch, etc to artifact files. this function is not available yet. Many thanks to Paul Holzinger for autocompletion PRs and review PRs that fixed issues early on. Also fix up some Args function to specify the correct number of args. Signed-off-by: Paul Holzinger <pholzing@redhat.com> Signed-off-by: Brent Baude <bbaude@redhat.com>
Removes the windows installer patch for upgrading from v5.3.1 to v5.3.x that was introduced in containers#24827. We need to do that because windows patches are allowed only for small and minor updates https://learn.microsoft.com/en-us/windows/win32/msi/patching-and-upgrades. We also need to start blocking upgrades from v5.3.1 to v5.4.x, which will be implemented in a separate commit. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
|
do you want to take this to the main branch and I can rebase to grab it ? |
|
As you prefer. I have created a PR against main branch too. |
baude
force-pushed
the
artifactrebase
branch
3 times, most recently
from
15911b8 to
d2b1e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?
Removes the windows installer patch for upgrading from v5.3.1 to v5.3.x that was introduced in containers#24827.
We need to do that because windows patches are allowed only for small and minor updates https://learn.microsoft.com/en-us/windows/win32/msi/patching-and-upgrades.
We also need to start blocking upgrades from v5.3.1 to v5.4, which will be implemented in a separate PR.