feat(context): add json marshal error handler to error bubble

bastean · May 26, 2024 · 68819fe · 68819fe
1 parent 77eb4a9
commit 68819fe
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 16 deletions.
diff --git a/pkg/context/shared/domain/serror/bubble.go b/pkg/context/shared/domain/serror/bubble.go
@@ -22,7 +22,12 @@ func (err *Bubble) Error() string {
 	message := fmt.Sprintf("%s (%s): %s", err.When.Format(time.RFC3339Nano), err.Where, err.What)
 
 	if err.Why != nil {
-		why, _ := json.Marshal(err.Why)
+		why, err := json.Marshal(err.Why)
+
+		if err != nil {
+			sservice.PanicOnError("Error", fmt.Sprintf("cannot json encoding why from error bubble: %s: [%s]", message, err.Error()))
+		}
+
 		message = fmt.Sprintf("%s: %s", message, why)
 	}
 
@@ -35,11 +40,11 @@ func (err *Bubble) Error() string {
 
 func NewBubble(where, what string, why Meta, who error) *Bubble {
 	if where == "" {
-		sservice.PanicOnError("NewBubble", "cannot create a bubble if where is not defined")
+		sservice.PanicOnError("NewBubble", "cannot create a error bubble if where is not defined")
 	}
 
 	if what == "" {
-		sservice.PanicOnError("NewBubble", "cannot create a bubble if what is not defined")
+		sservice.PanicOnError("NewBubble", "cannot create a error bubble if what is not defined")
 	}
 
 	return &Bubble{

diff --git a/pkg/context/shared/domain/smodel/queryHandler.go b/pkg/context/shared/domain/smodel/queryHandler.go
@@ -1,5 +1,5 @@
 package smodel
 
-type QueryHandler[Query any, Response any] interface {
+type QueryHandler[Query, Response any] interface {
 	Handle(Query) (Response, error)
 }
diff --git a/pkg/context/shared/domain/smodel/useCase.go b/pkg/context/shared/domain/smodel/useCase.go
@@ -1,5 +1,5 @@
 package smodel
 
-type UseCase[Input any, Output any] interface {
+type UseCase[Input, Output any] interface {
 	Run(Input) (Output, error)
 }
diff --git a/pkg/context/user/application/read/query.handler.go b/pkg/context/user/application/read/query.handler.go
@@ -7,12 +7,8 @@ import (
 	"github.com/bastean/codexgo/pkg/context/user/domain/valueobj"
 )
 
-type Input struct {
-	Id smodel.ValueObject[string]
-}
-
 type QueryHandler struct {
-	smodel.UseCase[*Input, *aggregate.User]
+	smodel.UseCase[smodel.ValueObject[string], *aggregate.User]
 }
 
 func (handler *QueryHandler) Handle(query *Query) (*Response, error) {
@@ -22,9 +18,7 @@ func (handler *QueryHandler) Handle(query *Query) (*Response, error) {
 		return nil, serror.BubbleUp(err, "Handle")
 	}
 
-	user, err := handler.UseCase.Run(&Input{
-		Id: id,
-	})
+	user, err := handler.UseCase.Run(id)
 
 	if err != nil {
 		return nil, serror.BubbleUp(err, "Handle")

diff --git a/pkg/context/user/application/read/query.handler_test.go b/pkg/context/user/application/read/query.handler_test.go
@@ -14,7 +14,7 @@ import (
 type UserReadTestSuite struct {
 	suite.Suite
 	sut        smodel.QueryHandler[*read.Query, *read.Response]
-	useCase    smodel.UseCase[*read.Input, *aggregate.User]
+	useCase    smodel.UseCase[smodel.ValueObject[string], *aggregate.User]
 	repository *persistence.RepositoryMock
 }
 

diff --git a/pkg/context/user/application/read/read.go b/pkg/context/user/application/read/read.go
@@ -2,6 +2,7 @@ package read
 
 import (
 	"github.com/bastean/codexgo/pkg/context/shared/domain/serror"
+	"github.com/bastean/codexgo/pkg/context/shared/domain/smodel"
 	"github.com/bastean/codexgo/pkg/context/user/domain/aggregate"
 	"github.com/bastean/codexgo/pkg/context/user/domain/model"
 )
@@ -10,9 +11,9 @@ type Read struct {
 	model.Repository
 }
 
-func (read *Read) Run(input *Input) (*aggregate.User, error) {
+func (read *Read) Run(id smodel.ValueObject[string]) (*aggregate.User, error) {
 	user, err := read.Repository.Search(model.RepositorySearchCriteria{
-		Id: input.Id,
+		Id: id,
 	})
 
 	if err != nil {