Popover fix - from using in real apps #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
forsbergplustwo
commented
Feb 26, 2024
forsbergplustwo
commented
- Previous change to use append_to_body on Filters component caused Stimulus actions to not fire. So now we set the z-index properly, which fixes the original overlap issue.
forsbergplustwo
changed the title
forsbergplustwo
changed the title
kirillplatonov
added a commit
that referenced
this pull request
Mar 18, 2024
* Add ability to preview Polaris v12 * Pin the @shopify/polaris to 11.26 in package.json * Fix banners * Fix styling, buttons and typography * Add `polaris_html_classes` helper (#366) * Update html to better suit * Fix OptionList Checkbox styles (#367) * Update cards * Add Inter font (#371) * Fix path to font * Fix Modals * Scope ul css better on cards * Fix pagination * Fix ActionLists and Page -> ActionMenu * Minor padding adjustment * Fix NavigationList * Improve preview * Fix Popover * Fix filter popovers * Fix Tooltips * Improve banners v12 styles (#379) * Fix FormBuilder errors_summary rendering within page (#381) * Fix padding for card without title (#382) * Improve styles for banners within cards * Fix Buttons * Fix ActionList buttons * Fix ActionList--active * Fix CalloutCard * Fix SaveBar * Fix shadow of active primary button * Fix Headings * Make iconOnly buttons square * Fix card section borders * Fix path to font on production * Reduce font size of help text component * Fix card section border paddings * Fix list bottom margin * Adjust Polaris-FormLayout padding * Fix date and time input styles * Popover fix - from using in real apps (#391) * Remove unnecessary append_to_body argument * Reorganize css files (#398) --------- Co-authored-by: Bjorn Forsberg <bjorn@forsbergplustwo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.