Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generated files with spec improvements #159

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Add generated files with spec improvements #159

merged 9 commits into from
Nov 27, 2024

Conversation

Nuvindu
Copy link
Contributor

@Nuvindu Nuvindu commented Nov 13, 2024 •
edited
Loading

Description

Spec Improvements:

  • Added comprehensive descriptions for undocumented types which had been missing in the openapi spec.
  • Change the return type descriptions of the resource functions

@NipunaRanasinghe
Copy link
Contributor

@Nuvindu shall we update the PR description mentioning the purpose of this PR?

@Nuvindu Nuvindu changed the title Apply necessary changes to the OpenAPI spec Add generated files with spec improvements Nov 27, 2024
NipunaRanasinghe
NipunaRanasinghe approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nuvindu Nuvindu merged commit fae5295 into ballerina-platform:main Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuvindu @NipunaRanasinghe