Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB): Add spawns for Tenris Mirkblood room in Karazhan. #21638

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

heyitsbench
Copy link
Contributor

Changes Proposed:

This PR proposes changes to:

  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Sniffs (remember to share them with the open source community!)

Tests Performed:

This PR has been:

  • Tested by repeatedly querying to DB.

Known Issues and TODO List:

  • Mirkblood needs scripting, quest likely needs fixing.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Mar 2, 2025
@Kitzunu
Copy link
Member

Kitzunu commented Mar 2, 2025

I see I have messed something up

@heyitsbench
Copy link
Contributor Author

Bearing in mind that normally I would use UPDATEs with the *_template tables, but 190610 does not exist in AC's DB and thus must be inserted.

@sudlud sudlud merged commit fdd469b into azerothcore:master Mar 3, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Ready to be Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Events): Tenris Mirkblood's room is not spawned during Scourge Invasion.
4 participants