fix(novu): handle missing env variable in Novu components (#1302)

ayasofyazilim-clomerce · Feb 20, 2025 · 3aa63e1 · 3aa63e1
2 parents 2428029 + 66c6d57
commit 3aa63e1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/apps/web/src/app/[lang]/(main)/layout.tsx b/apps/web/src/app/[lang]/(main)/layout.tsx
@@ -52,7 +52,7 @@ export default async function Layout({children, params}: LayoutProps) {
             <Novu
               appId={process.env.NOVU_APP_IDENTIFIER || ""}
               appUrl={process.env.NOVU_APP_URL || ""}
-              subscriberId={session?.user?.novuSubscriberId || "0"}
+              subscriberId={session?.user?.novuSubscriberId || ""}
             />
           }
           prefix=""

diff --git a/apps/web/src/providers/novu.tsx b/apps/web/src/providers/novu.tsx
@@ -13,7 +13,7 @@ export default function NovuProvider({
   subscriberId: string;
   appUrl: string;
 }) {
-  if (!appId || !appUrl || !subscriberId) throw new Error("appId, appUrl and subscriberId are required");
+  if (!appId || !appUrl || !subscriberId) return children;
   return (
     <Novu applicationIdentifier={appId} backendUrl={appUrl} subscriberId={subscriberId}>
       {children}

diff --git a/apps/web/src/providers/providers.tsx b/apps/web/src/providers/providers.tsx
@@ -20,7 +20,7 @@ export default async function Providers({children}: ProvidersProps) {
         <NovuProvider
           appId={process.env.NOVU_APP_IDENTIFIER || ""}
           appUrl={process.env.NOVU_APP_URL || ""}
-          subscriberId={session?.user?.novuSubscriberId || "0"}>
+          subscriberId={session?.user?.novuSubscriberId || ""}>
           {children}
         </NovuProvider>
       </GrantedPoliciesProvider>

diff --git a/apps/web/src/utils/navbar/notification.tsx b/apps/web/src/utils/navbar/notification.tsx
@@ -8,8 +8,10 @@ import {} from "lucide-react";
 import {useRouter} from "next/navigation";
 
 export function Novu({appId, appUrl, subscriberId}: {appId: string; appUrl: string; subscriberId: string}) {
-  if (!appId || !appUrl || !subscriberId) throw new Error("appId, appUrl and subscriberId are required");
   const router = useRouter();
+
+  if (!appId || !appUrl || !subscriberId) return null;
+
   const defaultAppearance = {
     elements: {
       popoverContent: {

diff --git a/packages/ayasofyazilim-ui b/packages/ayasofyazilim-ui
+6 −1		src/organisms/auto-form/fields/phone.tsx
+4 −1		src/organisms/schema-form/widgets/phone.tsx
+3 −0		src/organisms/tiptap/index.tsx
+3 −7		tiptap/components/BlockEditor/BlockEditor.tsx
+1 −1		tiptap/extensions/ImageBlock/components/ImageBlockView.tsx
+9 −1		tiptap/styles/index.css