CloudFormation template for managing the project's AWS CodeBuild workflows #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love the changes. Thank you for doing all that work. |
|
Can do! |
This was referenced Aug 22, 2022
|
split out the other changes, and will get around later to updating this PR to focus only on |
to help maintainers with adding/modifying the CI workflows also adds helper script `ci/update-images.sh` for re-building and re-uploading the `ci/docker/*` images
bmoffatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Validating #154 threw me down a rabbit hole of regression testing. The biggest change I made was to resolve constantly waiting for AWS SDK build, by moving the step out of anymoved to #162 - This PR focuses now only on codifying the existing AWS CodeBuild CI workflows into a CloudFormation templateci/codebuild/*.ymland into the respectiveci/docker/*- to cache it for personal sanity.Adds:
CI support for ArchLinuxmoved to Add AWS CodeBuild workflow and Dockerfile for ArchLinux #161ci/docker/arch-linuxci/codebuild/arch-linux.ymlci/codebuild.ymlto model the AWS Code Build resourcesci/update-images.shfor re-building and re-uploading theci/docker/*imagesinstructions tomoved to Add instructions for executing the AWS CodeBuild workflows locally #160CONTRIBUTING.mdfor guidance on executing the CodeBuild testing locally based on https://docs.aws.amazon.com/codebuild/latest/userguide/use-codebuild-agent.htmlThis PR is for visibility - I am expecting some of the existing workflows to break,
and need still need to synthesize the new CodeBuild project resources into the account used for this project before the web hooks take effect(edit: I have deployed this stack, web hooks can be seen in this PR and other recent PRs). Testing of the new workflows was initially done by synthesizing into a separate account, and setting the target repository to the fork/branch this PR is based on.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.