fix(examples): Add project to examples dependencies
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicamest
changed the title
examples dependenciesproject to examples dependencies
markjschreiber
approved these changes
Oct 26, 2023
|
I am not averse to moving to Java 11. The main thinking for keeping to Java 8 was the idea that this Java version is still under long term support. However, people should really upgrade. Also JVM 11+ can run Jar files that were built in Java 8 so if they are using this project as a drop-in provider for an older application they should still be able to do that. Moving to version 2 is a good time to introduce this kind of change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes #223 (review). It is related to #202, the
examplessourceset was missing theprojectdependency.Another topic
Something that was found out while running the examples is that jvm 11 is required due to the version of
logback. Running with java 8 results in:According to logback page, version 1.3 supports java 8 and version 1.4 (introduced in #19 or #12) requires java 11. This brings the question, whether to downgrade the dependency so that using the library works for java > 8, or move to a new version of java (say 11) for the source and target of the library.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.