Fix FileSystemSigner with PKCS#12 files #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use *rsa.PrivateKey and *ec.PrivateKey types across the project to maintain consistency * Refactor Makefile so that it's easy to run the subset of tests that don't require non-trivial dependencies
030emily
reviewed
Feb 12, 2025
| .PHONY: test | ||
| test: test-certs | ||
| go test ./... -list . | grep -E '^Test[a-zA-Z0-9]+' | grep -vE 'TPMSigner|PKCS11Signer' | tr '\n' '|' | sed 's/|$$//' | xargs -t go test ./... -run | ||
|
|
||
| define CERT_RECIPE | ||
| @SUBJ=$$(echo "$@" | sed 's^\(.*/\)\?\([^/]*\)-cert.pem^\2^'); \ |
There was a problem hiding this comment.
This sed command does not seem to remove the -cert.pem suffix from the filename
There was a problem hiding this comment.
Works for me when using GNU sed (maybe you're using BSD sed?). As an example:
% echo "tst/certs/rsa-1024-md5-cert.pem" | sed 's^\(.*/\)\?\([^/]*\)-cert.pem^\2^'
rsa-1024-md5
There was a problem hiding this comment.
Got it. I just confirmed that it works when using GNU sed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may also want to change
sign-stringso that paths to PKCS#12 files can be passed in using the--private-keyflag. Currently, the--certificateflag has to be used (even if the container only contains a private key).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.