Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nlb changes feedback #5312

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Conversation

CaptainCarpensir
Copy link
Contributor

Addresses feedback on #5303 and #5284 from after they were merged

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@CaptainCarpensir CaptainCarpensir requested a review from a team as a code owner September 20, 2023 17:00
@CaptainCarpensir CaptainCarpensir requested review from huanjani and removed request for a team September 20, 2023 17:00
Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay thanks!!!

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51844 51740 +0.20
macOS (arm) 52688 52596 +0.17
linux (amd) 45596 45496 +0.22
linux (arm) 44868 44804 +0.14
windows (amd) 43060 42968 +0.21

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 89.47% and project coverage change: +0.05% 🎉

Comparison is base (0a4097d) 69.77% compared to head (1506c1b) 69.83%.
Report is 2 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5312      +/-   ##
============================================
+ Coverage     69.77%   69.83%   +0.05%     
============================================
  Files           296      296              
  Lines         44621    44747     +126     
  Branches        287      287              
============================================
+ Hits          31136    31248     +112     
- Misses        11974    11984      +10     
- Partials       1511     1515       +4     
Files Changed Coverage Δ
internal/pkg/manifest/validate.go 77.30% <88.88%> (+0.01%) ⬆️
...al/pkg/deploy/cloudformation/stack/transformers.go 87.96% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 0b9e362 into aws:mainline Sep 20, 2023
@CaptainCarpensir CaptainCarpensir deleted the nlb-feedback branch October 9, 2023 16:12
KollaAdithya pushed a commit to KollaAdithya/copilot-cli that referenced this pull request Oct 18, 2023
Addresses feedback on aws#5303 and aws#5284 from after they were merged



By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants