-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase required CMake version to 3.9 #2219
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
==========================================
- Coverage 79.06% 79.05% -0.01%
==========================================
Files 612 612
Lines 106483 106511 +28
Branches 15050 15052 +2
==========================================
+ Hits 84192 84206 +14
- Misses 21639 21652 +13
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. |
CMakeLists.txt
Outdated
@@ -1,4 +1,4 @@ | |||
cmake_minimum_required(VERSION 3.0) | |||
cmake_minimum_required(VERSION 3.9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The common runtime still supports older CMAKE versions via cmake_minimum_required(VERSION 3.9...3.31). If we merge this we break customers on older versions of CMAKE no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using the same minimum version: 3.9
. cmake_minimum_required(VERSION 3.9...3.31)
is setting the minimum to 3.9
and the maximum to 3.31
. I thought about adding that but figured that might cause issues if we forget to bump it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not set a maximum version. What it does is that it sets policies defined between 3.9 and 3.31.
Please, please use the 3.9...3.31
or at the very least bump it to any version pinned to an lts distro that you support.
51b1e01
ea9d342
to
51b1e01
Compare
Description of changes:
CMake 4.0 is coming out soon and requires cmake_minimum_required to be at least 3.5:
The common runtime and s2n-tls upgraded to 3.9 last year.
Call-outs:
This will break any customer using CMake version less than 3.9 which was released in November 2018
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.