Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BORINGSSL_FIPS_BREAK_FFC_DH #2216

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

andrewhop
Copy link
Contributor

Description of changes:

While working on the clang-format change I noticed it doesn't handle this well and converts it into a long list with a single element per line: /~https://github.com/andrewhop/aws-lc/blob/clang_format/crypto/fipsmodule/self_check/self_check.c#L722-L982. AWS-LC does not use this build flag for testing, instead we rely on break-kat.go to test and demonstrate the CAST can be broken: /~https://github.com/aws/aws-lc/blob/main/util/fipstools/break-kat.go#L38.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner February 24, 2025 20:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (493207c) to head (e4a7f9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2216      +/-   ##
==========================================
- Coverage   79.06%   79.04%   -0.02%     
==========================================
  Files         612      612              
  Lines      106327   106327              
  Branches    15023    15023              
==========================================
- Hits        84064    84048      -16     
- Misses      21611    21627      +16     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhop andrewhop merged commit 913af96 into aws:main Feb 28, 2025
110 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants