Remove BORINGSSL_FIPS_BREAK_FFC_DH #2216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While working on the clang-format change I noticed it doesn't handle this well and converts it into a long list with a single element per line: /~https://github.com/andrewhop/aws-lc/blob/clang_format/crypto/fipsmodule/self_check/self_check.c#L722-L982. AWS-LC does not use this build flag for testing, instead we rely on break-kat.go to test and demonstrate the CAST can be broken: /~https://github.com/aws/aws-lc/blob/main/util/fipstools/break-kat.go#L38.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.