Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'nasm' not 'yasm' #1630

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Use 'nasm' not 'yasm' #1630

merged 1 commit into from
Jun 10, 2024

Conversation

justsmth
Copy link
Contributor

Issues:

Resolves aws/aws-lc-rs#425

Context:

...\aesni-xts-avx512.asm:136: error: undefined symbol `zmm25' (first use)

Change:

  • This change has CMake locate the "nasm" executable, then sets that as the CMAKE_ASM_NASM_COMPILER.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth merged commit 4e54dd8 into aws:main Jun 10, 2024
95 of 98 checks passed
@justsmth justsmth deleted the nasm-not-yasm branch June 10, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many warnings from cmake and can't build with cc1.exe: all warnings being treated as errors
3 participants