Fix build for Open Harmony #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jschwe
reviewed
Jan 8, 2025
skmcgrail
previously approved these changes
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
- Coverage 95.80% 92.90% -2.90%
==========================================
Files 61 68 +7
Lines 8143 9721 +1578
Branches 0 9721 +9721
==========================================
+ Hits 7801 9031 +1230
- Misses 342 402 +60
- Partials 0 288 +288 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
fix-ohos
branch
5 times, most recently
from
bc23e2a to
dc6d0c1
Compare
justsmth
changed the title
skmcgrail
previously approved these changes
Jan 9, 2025
skmcgrail
previously approved these changes
Jan 10, 2025
samuel40791765
previously approved these changes
Jan 15, 2025
justsmth
dismissed stale reviews from samuel40791765 and skmcgrail
via
600fdad
skmcgrail
approved these changes
Jan 16, 2025
samuel40791765
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #648
Description of changes:
ccwhen a cmake toolchain is not provided.Testing:
aarch64-unknown-linux-ohos,armv7-unknown-linux-ohos, andx86_64-unknown-linux-ohos.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.