Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Commit

Permalink
fix: progress bar doesn't show any progress (#166)
Browse files Browse the repository at this point in the history
  • Loading branch information
IllyaYalovyy authored and Li committed Nov 15, 2021
1 parent f96489a commit 5b4a5b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions packages/cli/internal/pkg/aws/cdk/execute_cdk.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (

var ExecuteCdkCommand = executeCdkCommand
var execCommand = exec.Command
var progressRegex = regexp.MustCompile(`^\s*([0-9]+/[0-9]+)\s*\|(.*)`)
var progressRegex = regexp.MustCompile(`^.*\|\s*([0-9]+/[0-9]+)\s*\|(.*)`)

var osRemoveAll = os.RemoveAll

Expand Down Expand Up @@ -44,7 +44,6 @@ func executeCdkCommandAndCleanupDirectory(appDir string, commandArgs []string, t
if err != nil {
progressChan <- ProgressEvent{Err: err}
}

}()
return progressChan, nil
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/internal/pkg/aws/cdk/execute_cdk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
const (
testExecuteCommandSuccessArg = "test-execute-command-success-arg"
testExecuteCommandFailureArg = "test-execute-command-failure-arg"
testExecuteCommandProgressLine = " 3/10 |4:56:17 PM | CREATE_COMPLETE | AWS::IAM::Policy | TaskBatch/BatchRole/DefaultPolicy (TaskBatchBatchRoleDefaultPolicyB9AAE3A1)"
testExecuteCommandProgressLine = "Agc-Context-Demo-yy110HKO4J-ctx1 | 3/10 | 3:22:16 PM | REVIEW_IN_PROGRESS | AWS::CloudFormation::Stack | Agc-Context-Demo-yy110HKO4J-ctx1 User Initiated"
)

func fakeExecCommand(command string, args ...string) *exec.Cmd {
Expand Down

0 comments on commit 5b4a5b4

Please sign in to comment.