Add code sync up workflow #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suniltheta
approved these changes
Mar 31, 2023
XinyiZhangAws
approved these changes
Mar 31, 2023
| - name: Configure AWS Credentials | ||
| uses: aws-actions/configure-aws-credentials@v2 | ||
| with: | ||
| role-to-assume: arn:aws:iam::377429403256:role/github-codesync-role |
There was a problem hiding this comment.
I don't see this role created for the account. What permissions are attached to it and how are we limiting access only to this github action?
There was a problem hiding this comment.
This role is created by an internal code commit. You can find it under our code repo. And it has limited to only github can assume it and push code to GitHubServiceConnectAgent.
karanvasnani
approved these changes
Mar 31, 2023
ytsssun
reviewed
Mar 31, 2023
| role-session-name: prodrolesession | ||
| aws-region: us-west-2 | ||
| - name: Sync up to CodeCommit | ||
| uses: tsgit18/sync-up-to-codecommit-action@v1.0.6 |
There was a problem hiding this comment.
Do we need to watch out for updates of this action?
There was a problem hiding this comment.
Good point. Currently it's enough for us. If there is a significant change for it, then we can update to a new version. I think we won't need to update it very often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add automatic code sync to CodeCommit repository.
Implementation details
Add two GitHub actions to sync up code to beta and prod CodeCommit repositories.
Testing
Tested in my personal account.
New tests cover the changes: no
Description for the changelog
Add code sync up workflow
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.