Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTel-http port to match the specification #1277

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

vasireddy99
Copy link
Contributor

Description:

This PR updates the OTel http port to 4318, it includes the changes that might have missed in previous PR's

Reference:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vasireddy99 vasireddy99 requested a review from a team as a code owner June 1, 2022 20:48
Copy link
Contributor

@bryan-aguilar bryan-aguilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent in whether or not we provide default points. I suggest we do not provide the endpoint field at all for any otlp receivers.

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:55681
endpoint: 0.0.0.0:4318
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4318

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:55681
endpoint: 0.0.0.0:4318
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4318

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:55681
endpoint: 0.0.0.0:4318
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4318

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:55681
endpoint: 0.0.0.0:4318
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4318

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4317

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4317

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4317

@@ -7,7 +7,7 @@ receivers:
grpc:
endpoint: 0.0.0.0:4317
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint: 0.0.0.0:4317

@vasireddy99
Copy link
Contributor Author

We should be consistent in whether or not we provide default points. I suggest we do not provide the endpoint field at all for any otlp receivers.

We are currently providing default end points in all of the configs such as in here, since default will likely to not change much often from now, I think it will be okay?.

@bryan-aguilar
Copy link
Contributor

We should be consistent in whether or not we provide default points. I suggest we do not provide the endpoint field at all for any otlp receivers.

We are currently providing default end points in all of the configs such as in here, since default will likely to not change much often from now, I think it will be okay?.

Ahh I see, so the apprunner config is the only one that does not specify defaults. So this is merely a preference of styling. I could go either way on this and don't know if there is a good argument for keeping or leaving them.

@vasireddy99 vasireddy99 merged commit 9ce2f0a into aws-observability:main Jun 16, 2022
@vasireddy99 vasireddy99 deleted the update-http-port branch June 16, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants