-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTel-http port to match the specification #1277
Update OTel-http port to match the specification #1277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be consistent in whether or not we provide default points. I suggest we do not provide the endpoint
field at all for any otlp
receivers.
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 | |||
http: | |||
endpoint: 0.0.0.0:55681 | |||
endpoint: 0.0.0.0:4318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4318 |
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 | |||
http: | |||
endpoint: 0.0.0.0:55681 | |||
endpoint: 0.0.0.0:4318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4318 |
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 | |||
http: | |||
endpoint: 0.0.0.0:55681 | |||
endpoint: 0.0.0.0:4318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4318 |
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 | |||
http: | |||
endpoint: 0.0.0.0:55681 | |||
endpoint: 0.0.0.0:4318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4318 |
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4317 |
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4317 |
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4317 |
@@ -7,7 +7,7 @@ receivers: | |||
grpc: | |||
endpoint: 0.0.0.0:4317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint: 0.0.0.0:4317 |
We are currently providing default end points in all of the configs such as in here, since default will likely to not change much often from now, I think it will be okay?. |
Ahh I see, so the |
Description:
This PR updates the OTel http port to
4318
, it includes the changes that might have missed in previous PR'sReference:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.