Verify digital signature after we have a signer/counter-signer to fix fileinfo crashes #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igner (#87). In #87, a fileinfo crash is reported when verifying the digital signature of attached PE files. What all the attached files have in common is that we are unable to find a signer or counter-signer for them and p7->length is 0. As the following comment in pe_format.cpp suggests, there is no point of continuing in such a case: // If we have no signer and countersigner, there must be something really bad if(!signerCert && !counterSignerCert) { BIO_free(bio); return; } Thus, move the signature verification AFTER the check that we have found a signer or a counter-signer. This fixes the signature-verifying crashes for all the files attached to #87.
This was referenced Mar 17, 2018
metthal
approved these changes
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #87,
fileinfocrashes are reported when verifying the digital signature of attached PE files. What all the attached files have in common is that we are unable to find a signer or counter-signer for them andp7->lengthis0. As the following comment inpe_format.cppsuggests, there is no point of continuing in such a case:Thus, move the signature verification AFTER the check that we have found a signer or a counter-signer. This fixes the signature-verifying crashes for all the files attached to #87.