Test the "--managed-save" option #6131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test results: |
bskjois
approved these changes
Jan 15, 2025
|
|
||
| def vm_undefine_check(vm_name): | ||
| """ | ||
| Check if vm can be undefined with manage-save option |
There was a problem hiding this comment.
it should be managed-save in the above line. Can be ignored as it is in commented block.
There was a problem hiding this comment.
Thank you! updated.
| ignore_status=True) | ||
| LOG.debug("%s", ret1) | ||
| if ret1.exit_status: | ||
| test.fail("Guest can't be undefine with " |
There was a problem hiding this comment.
undefined suits better than undefine
There was a problem hiding this comment.
Thank you! updated.
When the VM have a managedsave file, it can not be undefined without the "--managed-save" option. This option can remove the managedsave file and then undefine the VM. Signed-off-by: Yalan Zhang <yalzhang@redhat.com>
yalzhang
force-pushed
the
with_option_managed_save
branch
from
29f76f0 to
1772117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the VM have a managedsave file, it can not be undefined without the "--managed-save" option. This option can remove the managedsave file and then undefine the VM. (automate VIRT-297771)