-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build_info metric and use it in generated queries #35
Merged
Merged
Changes from 19 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
93abf6b
Add blurb to readme about identifying commits
brettimus 49f6d90
Remove "coming soon" from readme item on adding links to live Prom ch…
brettimus 41d7649
Add WIP section to the readme on using build info (version/commit)
brettimus cd38170
Add constants
brettimus 3d5cc9c
Initialize Prometheus Gauge for build_info
brettimus 3cee169
Add updown counter for build info to otel tracker
brettimus 936ed06
Implement set_build_info for OTEL and Prom, and call when we set the …
brettimus 44ac3c5
Update README
brettimus 2d21708
Move set_build_info call into create_tracker
0d7db6e
Update prometheus queries
02ad205
Update prometheus URL tests
9a3b55a
Add test for build_info gauge for prometheus tracker (skipped test fo…
cd74486
Checkpoint (saving work for later reference)
f20e973
Update otel tracker and tracker tests after finding otel prometheus bug
c362620
Update env vars we mention in README (still needs more thought)
034406a
Ensure set_build_info is only called once
b1eef93
Fix "call once" logic of set_build_info
brettimus a071249
Remove commented out test
brettimus 5bcc0ba
Update changelog
brettimus 894c224
Remove unnecessary commented-out print statements
brettimus b58510f
Add set_build_info to the TrackMetrics Protocol
brettimus 7163175
Fix build_info query based off of autometrics-dev/autometrics-shared#8
brettimus c44a621
Rename create_tracker to init_tracker
c916061
Use types instead of ifs
b754103
Update pyright
4cb6cd4
Update README to mention OpenTelemetry tracker does not work with bui…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grafana dashboards use a slightly different query:
Perhaps we should do this here as well? Here's the PR with the related change on the autometrics-shared repo: autometrics-dev/autometrics-shared#8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good catch! i updated the queries + tests